This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Use one window for all specs in the suite on more integration tests #4635
+239
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| describe("Working with unsaved changes", function () { | ||
| describe("CSS Intgration Tests", function () { |
There was a problem hiding this comment.
This File is a mess, but I just moved both integration suits from this file to this new suite used to create and destroy the window.
ghost
assigned 
|
Reviewing |
|
|
||
| // open file | ||
| runs(function () { | ||
| FileViewController.openAndSelectDocument(path, FileViewController.PROJECT_MANAGER) |
There was a problem hiding this comment.
Can remove didOpen, gotError and the waitsFor below, then replace this with
waitsForDone(FileViewController.openAndSelectDocument(path, FileViewController.PROJECT_MANAGER), "FILE_OPEN on file timeout", 1000);
|
Merging. My note about cleaning up promise handling can really apply to most of our unit tests that were created before |
jasonsanjose
added a commit
that referenced
this pull request
Aug 2, 2013
Use one window for all specs in the suite on more integration tests
|
Filed #4638 |
This was referenced Aug 2, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just integrated the specs on the following tests into a single window:
@jasonsanjose Want to review these too? Most were pretty simple to join and all tests are passing fast!!
Is so much nicer to run all integration tests now :)